dataflake.org

Home Documentation Software Old Stuff

mainloop() may do log_file.write() after log_file.close() (Resolved)

Request MaildropHost -- bug report -- by Nils R Grotnes
Posted on Mar 22, 2009 11:58 am
Subscribe

Enter your email address to receive mail on every change to this issue.

Entries (Latest first)


  Resolve by Jens Vagelpohl on Mar 23, 2009 11:03 am
  Thanks, this is now fixed in SVN:

http://svn.dataflake.org/viewvc?view=rev&revision=1745

 

  Initial Request by Nils R Grotnes on Mar 22, 2009 11:58 am
  In maildrop.py, the while len(to_be_sent) loop contains multiple log_file.close() statements, followed by a break out of the loop. Right after the loop, there's a log_file.write(finish_msg) that in these cases will raise an error.

In our case crashing maildrop.py, though I suppose that depends on the calling code.

In any case, the code flow should allow for just removing the early log_file.close() statements, since this will always be done after the while loop has been exited.

This fix works for us.