dataflake.org

Home Documentation Software Old Stuff Bug Reporting

1.15: ADD_MESSAGEID can't be turned off (Resolved)

Request MaildropHost -- bug report -- by Maik Jablonski
Posted on Mar 16, 2006 3:43 am
Subscribe

Enter your email address to receive mail on every change to this issue.

Entries (Latest first)


  Resolve by Jens Vagelpohl on Mar 16, 2006 6:05 am
  Thanks Maik, this is fixed now (slightly differently) in Subversion.
 

  Initial Request by Maik Jablonski on Mar 16, 2006 3:43 am
  If ADD_MESSAGEID in config.py is set to MaildropHost adds an message-id, too.

Problem is here. The existing expression evaluates to "Off" if ADD_MESSAGEID is set to 0. The second expression does work as expected:

109c109
< add_messageid = ADD_MESSAGEID and 'On' or 'Off'
---
> add_messageid = ADD_MESSAGEID and 1 or 0

Later on add_messageid is checked and is always true:

if self.add_messageid:
body = 'Message-Id: %s\n%s' % (make_msgid(), body)

Cheers, Maik