| Request | LDAPMultiPlugins -- bug report -- by Wichert Akkerman |
| Posted on | Feb 2, 2006 8:35 am |
| Subscribe |
| Resolve by Jens Vagelpohl on Feb 2, 2006 6:26 pm | |
|
That's a stupid one, thanks for pointing that out! Checked in now. |
|
|
|
| Initial Request by Wichert Akkerman on Feb 2, 2006 8:35 am | |
|
enumerateUsers checks if a DN is already seen, but stores a quoted version of the DN in the seen list. If the quoted version is different from the the unquoted version this test will always fail. Patch is below. Index: ActiveDirectoryMultiPlugin.py =================================================================== --- ActiveDirectoryMultiPlugin.py (revision 1269) +++ ActiveDirectoryMultiPlugin.py (working copy) @@ -293,7 +293,7 @@ quoted_dn = quote_plus(l_res['dn']) l_res['editurl'] = '%s?user_dn=%s' % (edit_url, quoted_dn) result.append(l_res) - seen.append(quoted_dn) + seen.append(l_res['dn']) if sort_by is not None: result.sort(lambda a, b: cmp( a.get(sort_by, '').lower() Index: LDAPMultiPlugin.py =================================================================== --- LDAPMultiPlugin.py (revision 1269) +++ LDAPMultiPlugin.py (working copy) @@ -200,7 +200,7 @@ quoted_dn = quote_plus(l_res['dn']) l_res['editurl'] = '%s?user_dn=%s' % (edit_url, quoted_dn) result.append(l_res) - seen.append(quoted_dn) + seen.append(l_res['dn']) if sort_by is not None: result.sort(lambda a, b: cmp( a.get(sort_by, '').lower() |
