| Request | LDAP User Folder -- feature request -- by Dirk Bergstrom |
| Posted on | Jul 27, 2005 2:56 pm |
| Subscribe |
| Resolve by Jens Vagelpohl on Jul 28, 2005 4:28 pm | |
|
Thanks for the very nice set of patches and tests. The changes are incorporated into version 2.6beta2, which I just pushed out: http://www.dataflake.org/software/ldapuserfolder/ldapuserfolder_2.6beta2 jens |
|
|
|
| Comment by Dirk Bergstrom on Jul 28, 2005 3:06 pm | |
|
JTracker was heard to exclaim, On 07/28/05 00:53: > The patches look OK, but do you realize that the unit tests don't > test the functionality at all? They only test setting the attribute > on the user folder, but not the expected behavior... Yeah, I was a bit lazy. I just made sure that my change wouldn't break the existing tests, and didn't look any further. I wrote up a test method that should do the trick. It's posted on my site at: http://otisbean.com/stuff/LDUF-test-method.py I put it in the testsuite right above testGroupMapping. |
|
|
|
| Comment by Jens Vagelpohl on Jul 28, 2005 3:53 am | |
|
Hi Dirk, The patches look OK, but do you realize that the unit tests don't test the functionality at all? They only test setting the attribute on the user folder, but not the expected behavior... jens |
|
|
|
| Initial Request by Dirk Bergstrom on Jul 27, 2005 2:56 pm | |
|
Because of the way we manage LDAP groups, the old implicit mapping of Zope roles to LDAP groups was a very valuable feature for us. I understand the reasons why it was removed, but they don't apply to us. So I've added a new property to LDUF, along with the necessary changes to dtml and the unit tests. All the tests pass, and everything appears to work. I hope that you will accept this patch. I've posted the patch on my website here: http://otisbean.com/stuff/LDUF-implicit-mapping-patch.txt Please let me know if you have any questions or comments. Thanks. |
